-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package names of INBO package #171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Els! Everything looks OK 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @ElsLommelen !
Considering the absence of R code in inbo_software/index.Rmd
, I'd suggest to delete this file after processing some comments, and only work in index.md
. Perhaps you can use the markdown table from Rmd and paste it into the md in that process, it appears a bit easier layouted to work in.
We should take into account the edits of #160 and #162, where only the md file was changed; I've noticed that some parts (but not all?) from those PRs got lost in the current PR.
- **R package [forrescalc](https://github.com/inbo/forrescalc)**: | ||
provides aggregated values on dendrometry, regeneration and vegetation of the flemish forest reserve monitoring network, and functions to derive these data starting from individual tree measurements in Fieldmap. | ||
- **R package [inbodb]((https://inbo.github.io/inbodb)**: | ||
connect to and retrieve data from databases on the INBO server, with dedicated functions to query databases INBOVEG and Florabank. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, generalize on the specific databases. More may be added in the future and then you need to update it here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was also my first consideration, but as newly added databases may contain environmental data, it is likely that the whole description has to be moved anyway after adding new databases... So I rather wait for the decision on the best category for this package. (Strange: I added this to our discussion on issue #37 yesterday, but is has disappeared.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange: I added this to our discussion on issue #37 yesterday, but is has disappeared
Never seen that 🤔, probably didn't come through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote it shortly before the github downtime yesterday, I'll redo it.
| Store data | [git2rdata](https://inbo.github.io/git2rdata/) | | ||
| Validate data | [pywhip](https://inbo.github.io/pywhip/) | | ||
| Analyze data: graphs | [inboggvegan](https://github.com/inbo/inboggvegan) | | ||
| Analyze data: models | [inlatools](https://inlatools.netlify.com/), [multimput](https://github.com/inbo/multimput), [effectclass](https://effectclass.netlify.com), [niche\_vlaanderen](https://inbo.github.io/niche_vlaanderen/), [gwloggeR](https://dov-vlaanderen.github.io/groundwater-logger-validation/gwloggeR/docs/articles/gwloggeR.html) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ElsLommelen can you re-insert this part? It was added in #160 but only in the md
file.
Co-authored-by: Floris Vanderhaeghe <[email protected]>
Co-authored-by: Floris Vanderhaeghe <[email protected]>
Co-authored-by: Floris Vanderhaeghe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks; a few minor suggestions left.
@@ -30,19 +30,19 @@ the package’s purpose and demonstrating its use. | |||
|
|||
The following table gives a **quick overview**: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to delete in the md file the many generated extra spaces (cf. my earlier comment: use the one from the Rmd file)
Co-authored-by: Floris Vanderhaeghe <[email protected]>
Thanks a lot @ElsLommelen, feel free to merge if you are ready to. |
This PR makes some minor changes following changes in INBO packages (partly related to issue #37):
forrescalc
inbodb
inborutils
toinbodb
(description of
inbodb
added toretrieve data: biological data
)